Skip to content

COMPAT: empty IntervalIndexis np.int64 dtype #19106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2018
Merged

COMPAT: empty IntervalIndexis np.int64 dtype #19106

merged 1 commit into from
Jan 7, 2018

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jan 6, 2018

@jreback jreback added 32bit 32-bit systems Compat pandas objects compatability with Numpy or Python functions Interval Interval data type Testing pandas testing functions or related to the test suite labels Jan 6, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 6, 2018
@jreback
Copy link
Contributor Author

jreback commented Jan 6, 2018

cc @jschendel

32-bit is quite difficult to test, our wheels do it once a day.

@codecov
Copy link

codecov bot commented Jan 7, 2018 •
edited
Loading

Codecov Report

Merging #19106 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19106      +/-   ##
==========================================
+ Coverage   91.51%   91.54%   +0.02%     
==========================================
  Files         148      148              
  Lines       48754    48754              
==========================================
+ Hits        44619    44631      +12     
+ Misses       4135     4123      -12
Flag Coverage Δ
#multiple 89.91% <100%> (+0.02%) ⬆️
#single 41.61% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/interval.py 92.19% <100%> (ø) ⬆️
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbfbe48...885b76f. Read the comment docs.

@jreback jreback merged commit e1d525c into pandas-dev:master Jan 7, 2018
@jschendel
Copy link
Member

Thanks, will keep this in mind on future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
32bit 32-bit systems Compat pandas objects compatability with Numpy or Python functions Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jreback @jschendel